Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test deploy scripts #49

Merged
merged 1 commit into from
Sep 26, 2024
Merged

test deploy scripts #49

merged 1 commit into from
Sep 26, 2024

Conversation

aazhou1
Copy link

@aazhou1 aazhou1 commented Sep 26, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Introduced two new GitHub Actions workflows for deploying Yearn strategies and vaults on the Sepolia test network.
    • Added new Solidity scripts for deploying Strategy and VaultManagement contracts, enabling streamlined deployment and configuration processes.

  • Chores

    • Added new submodules to enhance project dependencies.
    • Updated configuration files to include new remappings for Yearn libraries.

@aazhou1 aazhou1 self-assigned this Sep 26, 2024
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 26, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces two new GitHub Actions workflows for deploying Yearn strategies and vaults on the Sepolia test network. It also adds two submodules related to Yearn libraries, updates the foundry.toml configuration file with new remappings, and includes new Solidity scripts for deploying strategies and vaults. These changes enhance the project's deployment capabilities by providing structured workflows and necessary configurations.

Changes

File Change Summary
.github/workflows/deploy-sepolia-*.yaml Two new workflow files added for deploying strategies and vaults on Sepolia, each with input parameters and steps for deployment.
.gitmodules Two new submodules added: lib/yearn-vaults-v3 and lib/vault-periphery, expanding project dependencies.
foundry.toml Two new remappings added for Yearn vaults and vault periphery libraries.
lib/vault-periphery New subproject commit added, indicating an update in the vault-periphery directory.
lib/yearn-vaults-v3 New subproject commit added, indicating an update in the yearn-vaults-v3 directory.
script/Strategy.s.sol New Solidity script for deploying a Strategy contract and a TermVaultEventEmitter, including environment variable handling and logging.
script/VaultManagement.s.sol New Solidity script for deploying and configuring vault and accountant contracts, with logging and environment variable handling.

Possibly related PRs

  • Various strategy fixes #9: Enhancements to the Strategy contract relevant to the deployment of strategies on Sepolia.
  • fix comments and cleanup #11: Changes to the Strategy contract that improve documentation and cleanup, aiding in the understanding of the deployment process.

🐰 In the meadow, new workflows bloom,
Deploying strategies, vaults make room.
With Yearn's libraries, we hop with glee,
On Sepolia's stage, our contracts run free!
A dance of code, in harmony we play,
Cheers to the changes, hip-hip-hooray! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aazhou1 aazhou1 merged commit d625e90 into master Sep 26, 2024
0 of 4 checks passed
@aazhou1 aazhou1 deleted the test-deploy-scripts branch September 26, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aazhou1 aazhou1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aazhou1